Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/prometheus/client_golang from 1.19.1 to 1.20.0 #723

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 15, 2024

Bumps github.com/prometheus/client_golang from 1.19.1 to 1.20.0.

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.20.0

Thanks everyone for contributions!

⚠️ In this release we remove one (broken anyway, given Go runtime changes) metric and add three new (representing GOGC, GOMEMLIMIT and GOMAXPROCS flags) to the default collectors.NewGoCollector() collector. Given its popular usage, expect your binary to expose two additional metric.

Changes

  • [CHANGE] ⚠️ go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #1577
  • [FEATURE] ⚠️ go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #1568 #1578
  • [FEATURE] testutil: Add CollectAndFormat method. #1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #1537
  • [FEATURE] process-collectors: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #1455
  • [BUGFIX] promhttp: Make sure server instrumentation wrapping supports new and future extra responseWriter methods. #1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #1424

... (truncated)

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.20.0 / 2024-08-14

  • [CHANGE] ⚠️ go-collector: Remove go_memstat_lookups_total metric which was always 0; Go runtime stopped sharing pointer lookup statistics. #1577
  • [FEATURE] ⚠️ go-collector: Add 3 default metrics: go_gc_gogc_percent, go_gc_gomemlimit_bytes and go_sched_gomaxprocs_threads as those are recommended by the Go team. #1559
  • [FEATURE] go-collector: Add more information to all metrics' HELP e.g. the exact runtime/metrics sourcing each metric (if relevant). #1568 #1578
  • [FEATURE] testutil: Add CollectAndFormat method. #1503
  • [FEATURE] histograms: Add support for exemplars in native histograms. #1471
  • [FEATURE] promhttp: Add experimental support for zstd on scrape, controlled by the request Accept-Encoding header. #1496
  • [FEATURE] api/v1: Add WithLimit parameter to all API methods that supports it. #1544
  • [FEATURE] prometheus: Add support for created timestamps in constant histograms and constant summaries. #1537
  • [FEATURE] process-collectors: Add network usage metrics: process_network_receive_bytes_total and process_network_transmit_bytes_total. #1555
  • [FEATURE] promlint: Add duplicated metric lint rule. #1472
  • [BUGFIX] promlint: Relax metric type in name linter rule. #1455
  • [BUGFIX] promhttp: Make sure server instrumentation wrapping supports new and future extra responseWriter methods. #1480
  • [BUGFIX] testutil: Functions using compareMetricFamilies are now failing if filtered metricNames are not in the input. #1424

1.19.0 / 2024-02-27

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427

1.18.0 / 2023-12-22

  • [FEATURE] promlint: Allow creation of custom metric validations. #1311
  • [FEATURE] Go programs using client_golang can be built in wasip1 OS. #1350
  • [BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. #1367
  • [BUGFIX] testutil: Fix comparison of metrics with empty Help strings. #1378
  • [ENHANCEMENT] Improved performance of MetricVec.WithLabelValues(...). #1360

1.17.0 / 2023-09-27

  • [CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). #1325
  • [FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. #1313
  • [ENHANCEMENT] Enable detection of a native histogram without observations. #1314

1.16.0 / 2023-06-15

  • [BUGFIX] api: Switch to POST for LabelNames, Series, and QueryExemplars. #1252
  • [BUGFIX] api: Fix undefined execution order in return statements. #1260
  • [BUGFIX] native histograms: Fix bug in bucket key calculation. #1279
  • [ENHANCEMENT] Reduce constrainLabels allocations for all metrics. #1272
  • [ENHANCEMENT] promhttp: Add process start time header for scrape efficiency. #1278
  • [ENHANCEMENT] promlint: Improve metricUnits runtime. #1286

1.15.1 / 2023-05-3

  • [BUGFIX] Fixed promhttp.Instrument* handlers wrongly trying to attach exemplar to unsupported metrics (e.g. summary),
    causing panics. #1253

... (truncated)

Commits
  • 73b811c Cut 1.20.0 release. (#1580)
  • 7ce5089 gocollector: Attach original runtime/metrics metric name to help. (#1578)
  • 062300e Remove go_memstat_lookups_total; added runtime/metrics calculation to memstat...
  • aa3c00d Update common Prometheus files (#1576)
  • 3ad2722 Add default Go runtime metrics for /gc/gogc:percent, /gc/gomemlimit:bytes, /s...
  • 0715727 Update common Prometheus files (#1573)
  • 3634bd9 ci: daggerize test and lint pipelines (#1534)
  • 28b5e6e Merge pull request #1572 from prometheus/repo_sync
  • 8e18075 Update common Prometheus files
  • 46f77a9 Merge pull request #1571 from prometheus/dependabot/github_actions/github-act...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • Chores
    • Updated various dependency versions for improved performance, security, and compatibility.
    • Maintenance changes to keep libraries current and enhance overall application stability.

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.19.1...v1.20.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 15, 2024
@dependabot dependabot bot requested review from amimart and ccamel August 15, 2024 10:42
Copy link
Contributor

coderabbitai bot commented Aug 15, 2024

Walkthrough

The recent updates to the go.mod file primarily focus on upgrading various dependencies to their latest versions. This maintenance effort enhances security, performance, and compatibility across the project, ensuring that all libraries are up-to-date. Notable upgrades include critical libraries related to Prometheus and protocol buffers, reflecting an ongoing commitment to keeping the project robust and efficient.

Changes

Files/Dependencies Change Summary
github.com/prometheus/client_golang, github.com/prometheus/common, github.com/prometheus/procfs Updated to v1.20.0, v0.55.0, and v0.15.1 respectively
golang.org/x/net, golang.org/x/crypto, golang.org/x/oauth2, golang.org/x/sys, golang.org/x/term, golang.org/x/text, golang.org/x/tools Versions upgraded to v0.26.0, v0.24.0, v0.21.0, v0.22.0, v0.21.0, v0.16.0, and v0.21.1-0.20240508182429-e35e4ccd0d2d respectively
google.golang.org/protobuf, cloud.google.com/go/compute/metadata, github.com/klauspost/compress Updated to v1.34.2, v0.3.0, and v1.17.9 respectively

Poem

🐰 In the meadow of code, so fresh and bright,
New versions hop in, a delightful sight.
Dependencies dance, all shiny and new,
Enhancing our project, like morning dew.
With each little change, our worries take flight,
A codebase revitalized, a true delight! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6832b9a and 49eebcf.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (7 hunks)
Additional comments not posted (13)
go.mod (13)

48-48: Verify the impact of metric changes in github.com/prometheus/client_golang.

The update from v1.19.1 to v1.20.0 includes the removal of go_memstat_lookups_total and the addition of new metrics. Ensure that your monitoring setup is updated to reflect these changes.

Verification successful

No usage of removed metric go_memstat_lookups_total found.

The search did not find any usage of the go_memstat_lookups_total metric in the codebase, indicating that its removal in the update to v1.20.0 should not impact your monitoring setup. However, please manually verify that there are no other related issues due to the update.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for usage of the removed metric `go_memstat_lookups_total`.

# Test: Search for the removed metric in the codebase. Expect: No usage of the removed metric.
rg --type go 'go_memstat_lookups_total'

Length of output: 39


87-87: Verify the impact of updates in cloud.google.com/go/compute/metadata.

The version update from v0.2.3 to v0.3.0 may include bug fixes or new features. Verify if any breaking changes affect the application.


256-256: Verify the impact of updates in github.com/prometheus/procfs.

The version update from v0.13.0 to v0.15.1 may include bug fixes or new features. Verify if any breaking changes affect the application.

Verification successful

No direct usage of github.com/prometheus/procfs found in the codebase.

The dependency is marked as indirect, and no direct references were found in the codebase. This suggests that the update from v0.13.0 to v0.15.1 is unlikely to have a direct impact. However, consider verifying transitive dependencies that might rely on this package to ensure no indirect issues arise.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for breaking changes in `github.com/prometheus/procfs`.

# Test: Search for usage of `github.com/prometheus/procfs` in the codebase. Expect: No breaking changes.
rg --type go 'github.com/prometheus/procfs'

Length of output: 43


255-255: Verify the impact of updates in github.com/prometheus/common.

The version update from v0.52.2 to v0.55.0 may include bug fixes or new features. Verify if any breaking changes affect the application.


300-300: Verify the impact of updates in golang.org/x/sys.

The version update from v0.19.0 to v0.22.0 may include bug fixes or new features. Verify if any breaking changes affect the application.


296-296: Verify the impact of updates in golang.org/x/crypto.

The version update from v0.22.0 to v0.24.0 may include bug fixes or new features. Verify if any breaking changes affect the application.

Verification successful

No direct usage of golang.org/x/crypto found.

The golang.org/x/crypto package is not directly imported in the codebase. Since it is marked as an indirect dependency, its update from v0.22.0 to v0.24.0 is unlikely to have a direct impact. However, if there are concerns about indirect usage, a manual review of dependencies might be necessary.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for breaking changes in `golang.org/x/crypto`.

# Test: Search for usage of `golang.org/x/crypto` in the codebase. Expect: No breaking changes.
rg --type go 'golang.org/x/crypto'

Length of output: 34


Script:

#!/bin/bash
# Description: Check for indirect dependencies or usage of `golang.org/x/crypto`.

# Test: List all Go dependencies to see if `golang.org/x/crypto` is indirectly used.
go list -m all | grep 'golang.org/x/crypto'

Length of output: 113


Script:

#!/bin/bash
# Description: Search for import statements of `golang.org/x/crypto` in Go files.

# Test: Use ripgrep to find import statements of `golang.org/x/crypto` in Go files.
rg --type go 'import.*golang.org/x/crypto'

Length of output: 44


213-213: Verify the impact of updates in github.com/klauspost/compress.

The version update from v1.17.7 to v1.17.9 may include bug fixes or new features. Verify if any breaking changes affect the application.


59-59: Verify the impact of updates in golang.org/x/net.

The version update from v0.24.0 to v0.26.0 may include bug fixes or new features. Verify if any breaking changes affect the application.


301-301: Verify the impact of updates in golang.org/x/term.

The version update from v0.19.0 to v0.21.0 may include bug fixes or new features. Verify if any breaking changes affect the application.


302-302: Verify the impact of updates in golang.org/x/text.

The version update from v0.14.0 to v0.16.0 may include bug fixes or new features. Verify if any breaking changes affect the application.

Verification successful

No direct usage of golang.org/x/text found in the codebase.

The package golang.org/x/text is not directly imported in the codebase, suggesting that it is used as an indirect dependency. The update from v0.14.0 to v0.16.0 should not impact the codebase directly, but ensure that any indirect dependencies using it are compatible with this version.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for breaking changes in `golang.org/x/text`.

# Test: Search for usage of `golang.org/x/text` in the codebase. Expect: No breaking changes.
rg --type go 'golang.org/x/text'

Length of output: 32


Script:

#!/bin/bash
# Description: Find which dependencies import `golang.org/x/text`.

# Test: List all Go modules in the codebase that import `golang.org/x/text`.
go list -m all | grep 'golang.org/x/text'

Length of output: 111


Script:

#!/bin/bash
# Description: Search for import statements of `golang.org/x/text` in Go files.

# Test: Find all import statements of `golang.org/x/text`.
rg --type go 'import "golang.org/x/text"' -A 5

Length of output: 48


298-298: Verify the impact of updates in golang.org/x/oauth2.

The version update from v0.18.0 to v0.21.0 may include bug fixes or new features. Verify if any breaking changes affect the application.

Verification successful

Indirect Dependency Update for golang.org/x/oauth2

The update from version v0.18.0 to v0.21.0 is unlikely to impact the application directly, as it is an indirect dependency. However, reviewing the changelog or release notes for version v0.21.0 is recommended to ensure no critical changes affect other dependencies.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for breaking changes in `golang.org/x/oauth2`.

# Test: Search for usage of `golang.org/x/oauth2` in the codebase. Expect: No breaking changes.
rg --type go 'golang.org/x/oauth2'

Length of output: 34


Script:

#!/bin/bash
# Find which direct dependencies require `golang.org/x/oauth2`.
go mod graph | grep 'golang.org/x/oauth2'

# Check for recent changes in the `go.mod` file related to `golang.org/x/oauth2`.
git log -p -L '/golang.org\/x\/oauth2/',/^$/ -- go.mod

Length of output: 221


Script:

#!/bin/bash
# Search for dependencies in go.mod that might require `golang.org/x/oauth2`.
grep -A 5 'require (' go.mod

# Check for changes related to `golang.org/x/oauth2` in the go.mod file.
git log -p go.mod | grep -A 5 'golang.org/x/oauth2'

Length of output: 1026


62-62: Verify the impact of updates in google.golang.org/protobuf.

The version update from v1.33.0 to v1.34.2 may include bug fixes or new features. Verify if any breaking changes affect the application.


304-304: Verify the impact of updates in golang.org/x/tools.

The version update from v0.20.0 to v0.21.1-0.20240508182429-e35e4ccd0d2d may include bug fixes or new features. Verify if any breaking changes affect the application.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 21, 2024

Superseded by #728.

@dependabot dependabot bot closed this Aug 21, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/prometheus/client_golang-1.20.0 branch August 21, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants